-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-batcher: Add metrics for pending L2 transaction data size #5797
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
9d687d5
to
361c892
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5797 +/- ##
===========================================
- Coverage 42.22% 39.54% -2.69%
===========================================
Files 453 295 -158
Lines 29326 24692 -4634
Branches 877 0 -877
===========================================
- Hits 12384 9764 -2620
+ Misses 15985 14020 -1965
+ Partials 957 908 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
361c892
to
6872908
Compare
Semgrep found 1
Please create a Linear ticket for this TODO. Ignore this finding from todos_require_linear.Semgrep found 1
TODO in error handling code Ignore this finding from err-todo. |
* op-batcher: Add metrics for pending L2 transaction data size (ethereum-optimism#5797) * feat(op-node): Finalize Mainnet Rollup Config [release branch] (ethereum-optimism#5905) * copy over develop chainsgo * stage rollup config changes * final rollup config values * fix(op-batcher): solve race condition of BatchSubmitter publishTxToL1 and handleReceipt access state concurrently (#5) * chore: update readme, add testnet assets (ethereum-optimism#9) * chore: update readme, add testnet assets * doc: clarify readme * ci: add the ci code used to package and release docker images (ethereum-optimism#11) * ci: add the ci code used to package and release docker images (#7) * ci: add the ci code used to package and release docker images Co-authored-by: Welkin <welkin.b@nodereal.com> * fix: add latest tag for docker image (ethereum-optimism#9) Co-authored-by: Welkin <welkin.b@nodereal.com> * try to use cache for docker build (ethereum-optimism#10) Co-authored-by: Welkin <welkin.b@nodereal.com> --------- Co-authored-by: Welkin <welkin.b@nodereal.com> * feat(ci): add ci workflow * fix * fix * update * update * skip fail test temporarily * add batcher/proposer * add e2e * skip fail e2e case temporary * add op-node-lint * fix lint * add batcher/proposer lint * test junit-report * add junit report for all * adjust parallel to 2 for avoiding fail * add needs for job serial execution * use testname format to simplify result --------- Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: refcell.eth <abigger87@gmail.com> Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com> Co-authored-by: Owen <owen.h@nodereal.io> Co-authored-by: Welkin <welkin.b@nodereal.com>
Description
This adds metrics to track the size of pending blocks (rather than just the number).
It is expressed in a counter & a gauge. There is no new counter for the pending size
in channels because that counter already exists as the
input_bytes
metrics.Note: This is based off of the
op-batcher/v1.0.9-rc.1
tag.