Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: Add metrics for pending L2 transaction data size #5797

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

trianglesphere
Copy link
Contributor

Description

This adds metrics to track the size of pending blocks (rather than just the number).
It is expressed in a counter & a gauge. There is no new counter for the pending size
in channels because that counter already exists as the input_bytes metrics.

Note: This is based off of the op-batcher/v1.0.9-rc.1 tag.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

⚠️ No Changeset found

Latest commit: 6872908

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6872908
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64779e171652bb0008b4b699

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #5797 (361c892) into develop (df11f76) will decrease coverage by 2.69%.
The diff coverage is 14.81%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5797      +/-   ##
===========================================
- Coverage    42.22%   39.54%   -2.69%     
===========================================
  Files          453      295     -158     
  Lines        29326    24692    -4634     
  Branches       877        0     -877     
===========================================
- Hits         12384     9764    -2620     
+ Misses       15985    14020    -1965     
+ Partials       957      908      -49     
Flag Coverage Δ
bedrock-go-tests 39.54% <14.81%> (-0.03%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/metrics/metrics.go 0.00% <0.00%> (ø)
op-batcher/batcher/channel_manager.go 85.14% <100.00%> (+0.12%) ⬆️
op-batcher/metrics/noop.go 53.33% <100.00%> (+7.17%) ⬆️

... and 159 files with indirect coverage changes

op-batcher/metrics/metrics.go Outdated Show resolved Hide resolved
op-batcher/metrics/metrics.go Outdated Show resolved Hide resolved
op-batcher/metrics/metrics.go Outdated Show resolved Hide resolved
@semgrep-app
Copy link
Contributor

semgrep-app bot commented May 31, 2023

Semgrep found 1 todos_require_linear finding:

  • op-wheel/engine/engine.go: L124

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

Semgrep found 1 err-todo finding:

  • op-wheel/engine/engine.go: L124

TODO in error handling code

Ignore this finding from err-todo.

@trianglesphere trianglesphere changed the base branch from develop to release/bedrock-mainnet June 1, 2023 23:53
@trianglesphere trianglesphere marked this pull request as ready for review June 1, 2023 23:53
@trianglesphere trianglesphere requested a review from a team as a code owner June 1, 2023 23:53
@trianglesphere trianglesphere requested review from Inphi and removed request for a team June 1, 2023 23:53
@trianglesphere trianglesphere merged commit 70c10eb into release/bedrock-mainnet Jun 1, 2023
@trianglesphere trianglesphere deleted the jg/batcher_metrics branch June 1, 2023 23:53
keroro520 pushed a commit to keroro520/optimism that referenced this pull request Oct 20, 2023
* op-batcher: Add metrics for pending L2 transaction data size (ethereum-optimism#5797)

* feat(op-node): Finalize Mainnet Rollup Config [release branch] (ethereum-optimism#5905)

* copy over develop chainsgo

* stage rollup config changes

* final rollup config values

* fix(op-batcher): solve race condition of BatchSubmitter publishTxToL1 and handleReceipt access state concurrently (#5)

* chore: update readme, add testnet assets (ethereum-optimism#9)

* chore: update readme, add testnet assets

* doc: clarify readme

* ci: add the ci code used to package and release docker images (ethereum-optimism#11)

* ci: add the ci code used to package and release docker images (#7)

* ci: add the ci code used to package and release docker images

Co-authored-by: Welkin <welkin.b@nodereal.com>

* fix: add latest tag for docker image (ethereum-optimism#9)

Co-authored-by: Welkin <welkin.b@nodereal.com>

* try to use cache for docker build (ethereum-optimism#10)

Co-authored-by: Welkin <welkin.b@nodereal.com>

---------

Co-authored-by: Welkin <welkin.b@nodereal.com>

* feat(ci): add ci workflow

* fix

* fix

* update

* update

* skip fail test temporarily

* add batcher/proposer

* add e2e

* skip fail e2e case temporary

* add op-node-lint

* fix lint

* add batcher/proposer lint

* test junit-report

* add junit report for all

* adjust parallel to 2 for avoiding fail

* add needs for job serial execution

* use testname format to simplify result

---------

Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: refcell.eth <abigger87@gmail.com>
Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com>
Co-authored-by: Owen <owen.h@nodereal.io>
Co-authored-by: Welkin <welkin.b@nodereal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants