Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: Add bedrock-devnet script #3734

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Oct 19, 2022

Adds a bedrock-devnet script that deploys a local network using the Hardhat deploy scripts. I opted to write this in Python rather than Bash because we're starting to add complexity to our devnet setup, and I find Python much easier and safer to maintain.

Over time, I'll migrate the other devnet-up script to use this Python script as well.

To invoke this script, run make devnet-up-deploy. It's included in CI already as a separate testing job.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

⚠️ No Changeset found

Latest commit: fbf70ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mslipper mslipper requested review from smartcontracts and tynes and removed request for smartcontracts October 19, 2022 04:20
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Oct 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/bedrock-devnet-deploy-2 branch 2 times, most recently from 3594494 to 9e6eef5 Compare October 19, 2022 04:23
@github-actions github-actions bot removed A-pkg-contracts-bedrock Area: packages/contracts-bedrock 2-reviewers labels Oct 19, 2022
@github-actions github-actions bot added the A-pkg-sdk Area: packages/sdk label Oct 19, 2022
@mergify mergify bot added the sdk label Oct 19, 2022
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Oct 19, 2022
@mslipper mslipper force-pushed the feat/bedrock-devnet-deploy-2 branch 2 times, most recently from 0db91f3 to e2b88d1 Compare October 20, 2022 00:00
Adds a bedrock-devnet script that deploys a local network using the Hardhat deploy scripts. I opted to write this in Python rather than Bash because we're starting to add complexity to our devnet setup, and I find Python much easier and safer to maintain.

Over time, I'll migrate the other devnet-up script to use this Python script as well.

To invoke this script, run `make devnet-up-deploy`. It's included in CI already as a separate testing job.
@mslipper mslipper merged commit 896b5d5 into develop Oct 20, 2022
@mslipper mslipper deleted the feat/bedrock-devnet-deploy-2 branch October 20, 2022 20:22
nitaliano pushed a commit that referenced this pull request May 20, 2024
* ops: Add bedrock-devnet script

Adds a bedrock-devnet script that deploys a local network using the Hardhat deploy scripts. I opted to write this in Python rather than Bash because we're starting to add complexity to our devnet setup, and I find Python much easier and safer to maintain.

Over time, I'll migrate the other devnet-up script to use this Python script as well.

To invoke this script, run `make devnet-up-deploy`. It's included in CI already as a separate testing job.

* review updates

* Revert "review updates"

This reverts commit d01ba16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-sdk Area: packages/sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants