Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing: note how to install foundry #2710

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 7, 2022

Description
Add directions on how to install foundry to the contributing doc

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

⚠️ No Changeset found

Latest commit: c951b7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from mslipper and tuxcanfly June 7, 2022 21:09
@smartcontracts
Copy link
Contributor

smartcontracts commented Jun 7, 2022

@tynes
Copy link
Contributor Author

tynes commented Jun 7, 2022

Pls also add to dependencies: https://github.com/ethereum-optimism/optimism/blob/develop/CONTRIBUTING.md#dependencies

addressed, good catch

Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 198e8bf into develop Jun 8, 2022
@mergify mergify bot deleted the fix/install-deps branch June 8, 2022 01:05
@mergify mergify bot removed the on-merge-train label Jun 8, 2022
This was referenced Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants