Skip to content

Conversation

@pauldowman
Copy link
Contributor

@pauldowman pauldowman commented Dec 23, 2025

Description

check-prestate fails when op-geth is referenced as a go pseudo-version (v1.101604.0-synctest.0.0.20251208094937-ba6bdcfef423 ). This change extracts the version. Unfortunately this uses the commit hash instead of a tag, but if we had a pseudo-version it's probably because it was not tagged. I think it's fine to have an op-geth commit hash instead of tag in the prestate review output.

NOTE: This also sneaks in an unrelated commit to expect cannon64-kona instaed of cannon-kona as the default kona prestate type.

Tests

Additional context

Metadata

@pauldowman pauldowman requested review from a team and Inphi and removed request for a team December 23, 2025 17:44
@pauldowman pauldowman requested review from a team as code owners December 23, 2025 17:44
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.54%. Comparing base (722b12f) to head (5eb9aec).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18691      +/-   ##
===========================================
+ Coverage    66.89%   73.54%   +6.64%     
===========================================
  Files          189      189              
  Lines        11244    11244              
===========================================
+ Hits          7522     8269     +747     
+ Misses        3576     2831     -745     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 77.42% <ø> (+10.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pauldowman pauldowman force-pushed the pd/check-prestate-handles-pseudo-versions branch from 5eb9aec to 29f50e0 Compare December 23, 2025 17:55
@pauldowman pauldowman force-pushed the pd/check-prestate-handles-pseudo-versions branch from 29f50e0 to 3e8288f Compare December 23, 2025 18:15
@pauldowman pauldowman changed the title check-prestate: handle go module pseudo-versions check-prestate: handle go module pseudo-versions and fix kona prestate name Dec 23, 2025
@ajsutton ajsutton added this pull request to the merge queue Jan 4, 2026
Merged via the queue into develop with commit 2842468 Jan 4, 2026
92 checks passed
@ajsutton ajsutton deleted the pd/check-prestate-handles-pseudo-versions branch January 4, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants