Skip to content

op-{supervisor|e2e}: reorg when cycle detection + fix action test single chain cycle test #15569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: pcw109550/interop-cycle-detection-fix
Choose a base branch
from

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Apr 25, 2025

Description

Depends on #15568

op-e2e action tests for single chain cycle test was wrongly implemented. The chains reorged because the executing messages pointed to wrong index, not because of cycle.

This PR fixes the ExecTriggerFromInitTrigger method to generate correct executing messages for creating a cycle.

Tests

Fixes TestCycleInTx, TestCycleInBlock to use correct log index for executing message. Also checks that speculatively generated executing messages before transaction execution for emitting initiating messages are correct, comparing after the initiating message tx inclusion.

Additional context

Cycle errors were not considered as ErrConflict, and did not trigger reorgs. Wrap them and consider them as ErrConflict to trigger reorg.

Metadata

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.93%. Comparing base (8e169d8) to head (dfb5c96).

Files with missing lines Patch % Lines
...ptance-tests/tests/interop/interop_test_helpers.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           pcw109550/interop-cycle-detection-fix   #15569      +/-   ##
=========================================================================
- Coverage                                  46.67%   42.93%   -3.75%     
=========================================================================
  Files                                       1280     1108     -172     
  Lines                                     106109    95833   -10276     
=========================================================================
- Hits                                       49525    41143    -8382     
+ Misses                                     53093    51363    -1730     
+ Partials                                    3491     3327     -164     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-program/client/interop/consolidate.go 81.27% <100.00%> (-0.27%) ⬇️
op-supervisor/supervisor/backend/cross/cycle.go 71.77% <ø> (ø)
...ptance-tests/tests/interop/interop_test_helpers.go 6.21% <0.00%> (-0.19%) ⬇️

... and 180 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcw109550 pcw109550 added the M-do-not-merge Meta: Do not merge label Apr 25, 2025
@pcw109550 pcw109550 marked this pull request as ready for review April 25, 2025 15:56
@pcw109550 pcw109550 requested review from a team as code owners April 25, 2025 15:56
@pcw109550 pcw109550 requested review from ControlCplusControlV, protolambda, tyler-smith and axelKingsley and removed request for a team and ControlCplusControlV April 25, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-do-not-merge Meta: Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant