Skip to content

op-service: add support for enable/disable JWT auth per RPC handler route #15566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

nonsense
Copy link
Contributor

@nonsense nonsense commented Apr 25, 2025

Description

This PR is adding support for explicitly specifying authentication per RPC handler route, on top of the default JWT authentication.

Tests

I added TestHandlerAuthentication which tests RPC to the same service via differently setup authentication routes.

Additional context

Metadata

Fixes: #15565

@nonsense nonsense force-pushed the nonsense/optional-jwt-auth-per-rpc-handler-route branch from 4b18634 to 8b3d011 Compare April 25, 2025 12:00
@nonsense nonsense force-pushed the nonsense/optional-jwt-auth-per-rpc-handler-route branch 2 times, most recently from 472261b to a84ee1b Compare April 25, 2025 13:27
@nonsense nonsense requested a review from protolambda April 25, 2025 13:28
@nonsense nonsense marked this pull request as ready for review April 25, 2025 13:28
@nonsense nonsense requested a review from a team as a code owner April 25, 2025 13:28
@nonsense nonsense force-pushed the nonsense/optional-jwt-auth-per-rpc-handler-route branch from a84ee1b to 0411af0 Compare April 25, 2025 13:34
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.91%. Comparing base (8327047) to head (2c94bca).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-service/rpc/handler.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15566      +/-   ##
===========================================
- Coverage    46.78%   42.91%   -3.87%     
===========================================
  Files         1280     1108     -172     
  Lines       106114    95847   -10267     
===========================================
- Hits         49644    41135    -8509     
+ Misses       52969    51386    -1583     
+ Partials      3501     3326     -175     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-service/rpc/handler.go 84.72% <70.58%> (-2.60%) ⬇️

... and 177 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nonsense nonsense force-pushed the nonsense/optional-jwt-auth-per-rpc-handler-route branch from 0411af0 to 2c94bca Compare April 25, 2025 13:58
@protolambda protolambda added this pull request to the merge queue Apr 25, 2025
Merged via the queue into develop with commit c567422 Apr 25, 2025
53 checks passed
@protolambda protolambda deleted the nonsense/optional-jwt-auth-per-rpc-handler-route branch April 25, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-service: enable/disable JWT auth per RPC handler route
2 participants