feat: Simplify op-deployer scripts: Switch from legacy to the new scripts for DeploySuperchain & DeployImplementations [17/N] #15551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
from
5ae48b0 to
b333ffe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15551 +/- ##
============================================
+ Coverage 47.06% 96.24% +49.17%
============================================
Files 1360 106 -1254
Lines 109447 4575 -104872
============================================
- Hits 51512 4403 -47109
+ Misses 54279 172 -54107
+ Partials 3656 0 -3656
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
2 times, most recently
from
252a54f to
e5604f9
Compare
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
from
e5604f9 to
6335f6c
Compare
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
from
6335f6c to
15d6f8d
Compare
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
from
15d6f8d to
535a007
Compare
mslipper
approved these changes
May 9, 2025
mslipper
requested changes
May 9, 2025
…s & contract names of the new scripts
…filenames & types of the new wrappers
…uct. This step might not be necessary anymore
…ployment per CLI target so the Scripts struct needs to be created for every CLI target
…ract artifacts, after which the tests need to be updated and regression tests unskipped
janjakubnanista
force-pushed
the
jan/op-deployer--017
branch
from
aff9a86 to
adb450d
Compare
mslipper
approved these changes
May 22, 2025
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
…ipts for DeploySuperchain & DeployImplementations [17/N] (ethereum-optimism#15551) * step 1: Delete old scripts & tests; Remove the "2" from the file names & contract names of the new scripts * step 2: Update the downstream scripts * step 3: Delete the old opcm script wrappers; Remove the "2" from the filenames & types of the new wrappers * step 4.1: Create OPCM scripts struct in pipeline and ad it to Env struct. This step might not be necessary anymore * step 4.2: Adjust the pipeline scripts to use the new scripts * step 4.3: Adjust op-chain-ops * step 4.4: Adjust bootstrap scripts. In this case there is only one deployment per CLI target so the Scripts struct needs to be created for every CLI target * step 5: Skip the regression tests so that we can publish the new contract artifacts, after which the tests need to be updated and regression tests unskipped * rebase: Remove unused imports * fix: Misrebase * fix: Misrebase * fix: Misrebase * fix test --------- Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serves as a step-by-step guide for the
op-deployerscript migration. To follow the steps, please follow the commits and their messages. Some of the steps might not apply in your particular case.Questions
Q: There are regression tests that point to incompatible artifacts for existing networks.
@mslipper any opinions on this? Should we keep the tests (which also means we can't delete the old implementations of the scripts)? In general we are introducing a breaking change so at some point we'll drop the support for the old artifacts, the question is when.
A: The tests will be marked as skipped and will be unskipped once the new contract artifacts have been published
Notes
There was one particular concerning find in this PR, you can see it in this CI run. The legacy code in
deploy.gowas not being passed theSuperchainProxyAdminthat was supposed to be required by the contracts (this should have failed) - seeimplementations.gofor an example of correct usage.After upgrading to the new script, we got a correct EVM revert and a fix was introduced. The concerning thing is that this has not been caught in the CI, and no extra
requirestatements have been added to trigger this.