Skip to content

fix(kt-devnet): adjust to possible multiple depsets #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

sigma
Copy link
Member

@sigma sigma commented Apr 22, 2025

Description

The previous approach of associating a single dependency set to a
devnet doesn't work anymore, as we're aiming to work with multiple
interop sets, multiple supervisors, and so on.

We're also importing the corresponding optimism-package
version, and adjusting the interop devnet definition

Tests

deployed simple, isthmus and interop devnets

Additional context

Metadata

The previous approach of associating a single dependency set to a
devnet doesn't work anymore, as we're aiming to work with multiple
interop sets, multiple supervisors, and so on.

We're also importing the corresponding optimism-package
version, and adjusting the interop devnet definition
@sigma sigma requested a review from a team as a code owner April 22, 2025 20:58
@sigma sigma requested a review from josepmc April 22, 2025 20:58
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 8.10811% with 34 lines in your changes missing coverage. Please review.

Project coverage is 42.90%. Comparing base (de3a3e6) to head (9284959).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...tosis-devnet/pkg/kurtosis/sources/depset/depset.go 0.00% 22 Missing ⚠️
devnet-sdk/devstack/sysext/system.go 0.00% 11 Missing ⚠️
kurtosis-devnet/pkg/kurtosis/adapters.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15515      +/-   ##
===========================================
- Coverage    46.78%   42.90%   -3.88%     
===========================================
  Files         1277     1105     -172     
  Lines       105423    95172   -10251     
===========================================
- Hits         49323    40838    -8485     
+ Misses       52626    51034    -1592     
+ Partials      3474     3300     -174     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
kurtosis-devnet/pkg/kurtosis/kurtosis.go 83.23% <100.00%> (ø)
kurtosis-devnet/pkg/kurtosis/adapters.go 0.00% <0.00%> (ø)
devnet-sdk/devstack/sysext/system.go 0.00% <0.00%> (ø)
...tosis-devnet/pkg/kurtosis/sources/depset/depset.go 0.00% <0.00%> (ø)

... and 175 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma added this pull request to the merge queue Apr 22, 2025
Merged via the queue into develop with commit ac2d950 Apr 22, 2025
53 checks passed
@sigma sigma deleted the sigma/kt-devnet-multiple-supervisors branch April 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants