Skip to content

op-acceptance-tests: enable interop NAT tests at CI #15504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

pcw109550
Copy link
Contributor

Description

Enable interop NAT tests at CI.
Also splits out existing interop txplan tests to separate test, to make op-acceptor report the test results in a fine grained manner.

Depends on #15503. Develop branch acceptance test CI will fail if we merge this PR before the dep PR.

Tests

All NAT interop tests are passing using the op-acceptor. Relevant logs:

 Acceptance Testing Results (6m23s)                                                                                                     
 TYPE   ID                                                                           DURATION  TESTS  PASSED  FAILED  SKIPPED  STATUS   
 Gate   interop                                                                         6m23s      -      17       0        0  ✓ pass   
 Test   ├── github.com/ethereum-optimism/optimism/op-acceptance-tests/tests/interop     6m19s      1       1       0        0  ✓ pass   
            ├── TestMessagePassing                                                         7s      1       1       0        0  ✓ pass   
            ├── TestInteropInitAndExecMsg                                                 14s      1       1       0        0  ✓ pass   
            ├── TestInteropInitAndExecMultipleMsg                                         15s      1       1       0        0  ✓ pass   
            ├── TestInteropExecSameMsgTwice                                               15s      1       1       0        0  ✓ pass   
            ├── TestSystemWrapETH                                                          4s      1       1       0        0  ✓ pass   
            ├── TestInteropSystemNoop                                                      0s      1       1       0        0  ✓ pass   
            ├── TestInteropSystemSupervisor                                                0s      1       1       0        0  ✓ pass   
            ├── TestSmokeTestFailure                                                       0s      1       1       0        0  ✓ pass   
            ├── TestInteropExecMsgDifferentTopicCount                                     15s      1       1       0        0  ✓ pass   
            ├── TestInteropExecMsgDifferEventIndexInSingleTx                              14s      1       1       0        0  ✓ pass   
            ├── TestInteropRandomDirectedGraph                                          1m22s      1       1       0        0  ✓ pass   
            ├── TestInteropExecMsgOpagueData                                              14s      1       1       0        0  ✓ pass   
            └── TestInteropExecuteMessageInvalidAttributes                              2m43s      1       1       0        0  ✓ pass   
 Test   └── TestChainFork                                                                  4s      1       1       0        0  ✓ pass   
            ├── TestChainFork/Chain_0                                                      1s      1       1       0        0  ✓ pass   
            └── TestChainFork/Chain_1                                                      1s      1       1       0        0  ✓ pass   
 TOTAL                                                                               6M23S     17         17       0        0  ✓ PASS   

@pcw109550 pcw109550 added the M-do-not-merge Meta: Do not merge label Apr 22, 2025
@pcw109550 pcw109550 requested review from a team as code owners April 22, 2025 14:26
@pcw109550 pcw109550 requested review from zhwrd, tyler-smith, scharissis and teddyknox and removed request for zhwrd and tyler-smith April 22, 2025 14:26
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.69%. Comparing base (6e563de) to head (ed33e6f).
Report is 28 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15504       +/-   ##
============================================
+ Coverage    46.68%   81.69%   +35.00%     
============================================
  Files         1277      173     -1104     
  Lines       105374    10280    -95094     
============================================
- Hits         49198     8398    -40800     
+ Misses       52715     1715    -51000     
+ Partials      3461      167     -3294     
Flag Coverage Δ
cannon-go-tests-32 62.18% <ø> (ø)
cannon-go-tests-64 57.42% <ø> (ø)
contracts-bedrock-tests 94.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@scharissis scharissis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also look into modifying op-acceptor's test result reporting if that's preferable to adding a unique top-level go test.

pcw109550 and others added 2 commits April 26, 2025 01:01
Co-authored-by: Teddy Knox <teddy@oplabs.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-do-not-merge Meta: Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants