Skip to content

Add CHAINID and SELFBALANCE opcodes#150

Merged
K-Ho merged 2 commits intomasterfrom
YAS-413/Uniswap/CHAINID_SELFBALANCE
Jun 8, 2020
Merged

Add CHAINID and SELFBALANCE opcodes#150
K-Ho merged 2 commits intomasterfrom
YAS-413/Uniswap/CHAINID_SELFBALANCE

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Jun 8, 2020

Description

CHAINID, opcode 0x46 was added in the Istanbul hard fork and is used in Uniswap V2- update opcode types to add this opcode and whitelist it in both the SafetyChecker and Transpiler. Also adds the other opcode added in the hard fork, SELFBALANCE, 0x47 - this should be blacklisted for both the Transpiler and SafetyChecker

Metadata

Note, CHAINID still needs to be transpiled - this is listed as YAS-414

Fixes

  • Fixes #YAS-413

Contributing Agreement

ben-chain
ben-chain approved these changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@K-Ho K-Ho merged commit b76acbd into master Jun 8, 2020
@gakonst gakonst deleted the YAS-413/Uniswap/CHAINID_SELFBALANCE branch March 18, 2021 15:08
snario pushed a commit that referenced this pull request Apr 14, 2021
@tynes @ben-chain
ctc: disable appendQueueBatch (#150)
006acd9 
* ctc: disable appendSequencerBatch

* typo: fix

* re-enable verifyQueueTransaction test:

* add explicit test for verifying queue elements against either append

Co-authored-by: Ben Jones <ben@pseudonym.party>
snario pushed a commit that referenced this pull request Apr 14, 2021
@karlfloersch @smartcontracts
@ben-chain @axchu @tynes @K-Ho
Code freeze audit integrations (#163)
d34a12f 
* Separates storage from SCC and CTC (#151)

* First pass version

* More minor tweaks for tests to pass

* Add authentication

* Minor config updates

* Fix lint error

* Fix naming changes per review

* Enable Deployer Whitelist (#119)

* first pass, test runner updated

* add ability to only validate flag, test passes

* all tests passing

* clean up console.logs

* enforce gas refund preservation

* more cleanup/import removal

* whitelisted -> allowed

* first pass, test runner updated

* add ability to only validate flag, test passes

* all tests passing

* clean up console.logs

* enforce gas refund preservation

* more cleanup/import removal

* whitelisted -> allowed

* remove whitespace

* Restrict StateTransitionerFactory (#140)

* added msg sender check

* add create test

* cleanup

* add param

* add addressmanager.address param

* CTC Chain Monotonicity Fixes (#93)

* [wip] Fix block time logic

* some sad path and happy tests passing

* more progress

* first pass sad cases tested

* cleanup, adding empty tests

* more reversion tests

* rename shouldstartat}

* add final couple tests

* enable more tests

* cleanup

* remove .only

* textual cleanup

* make queue length public

* improve structure, comments

* update deploy config

* address nits

Co-authored-by: Karl Floersch <karl@karlfloersch.com>

* fix declarations, lint (#152)

* Adds river's new Merkle tree implementation, with some cleanup (#148)

* Reverts an accidental breaking merge

* Added new merkle tree impl

* add comments

* Final cleanups and merge

Co-authored-by: Ben Jones <ben@pseudonym.party>

* Fix run gas Lower Bound (#94)

* added the check

* add test

* lower OVM TX size for Kovan

* re-remove gas check

* update gas vals slightly

* lint

* lint

* Merge master into freeze integration branch  (#153)

* update solidity version to ^0.7.0 (#122)

* update solc version to ^0.7.0

* interfaces back to solidity >0.6.0 <0.8.0

* update solc to 0.7.6

* back to 0.7.4

* upgrade to 0.7.6, fix EXTCODESIZE check

* versions >0.5.0 <0.8.0 for xdomain msgers

* ctc: disable appendQueueBatch (#150)

* ctc: disable appendSequencerBatch

* typo: fix

* re-enable verifyQueueTransaction test:

* add explicit test for verifying queue elements against either append

Co-authored-by: Ben Jones <ben@pseudonym.party>

* fix up test

* remove .only

Co-authored-by: Alina <alina@optimism.io>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

* add check, simple test, update deploy (#154)

* go back to first name (#155)

* lint

* fix js number error

* add error logging to help debug deploy

* [code freeze] Fix deploy script (#156)

* fix deploy script

* add block time config

* ensure value is integer

* lint

* remove console logs from deploy

* Moves gas check to applyTransaction (#161)

* move to OVM_ST, pass test

* remove old test because functionality moved

* linting

* remove leaf hasing

* use safe EXEMRG wrapper (#162)

* use safeREQUIRE

* add owner getter

* relayer: add to config (#160)

* relayer: add to config

* lint: fix

* Fix minor error in test config

Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
Co-authored-by: ben-chain <ben@pseudonym.party>
Co-authored-by: Alina <alina@optimism.io>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>
blockchaindevsh pushed a commit to blockchaindevsh/optimism that referenced this pull request Jan 25, 2025
@syntrust
fix TestRequiredProtocolVersionChangeAndHalt (ethereum-optimism#150)
7901cae
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
feat(derive): Online Data Source Factory Wiring (#150)
af80e7b 
* feat(derive): online dap

* fix(derive): data source factory

* fix(derive): batch queue unit test
theochap pushed a commit that referenced this pull request Jan 15, 2026
@refcell
fix(rpc-types): Op Prefix Naming Convention (#162)
eca088e 
### Description

Modifies OP Stack types in `rpc-types` to use the `Op` prefix as opposed
to `Optimism` prefix.

### Metadata

Makes progress on #150
theochap pushed a commit that referenced this pull request Jan 15, 2026
@refcell
fix(rpc-types-engine): Op Prefix Naming Convention (#163)
72d7277 
### Description

Modifies OP Stack types in `rpc-types-engine` to use the `Op` prefix as
opposed to `Optimism` prefix.

### Metadata

Makes progress on #150
theochap pushed a commit that referenced this pull request Jan 15, 2026
@refcell
fix(genesis): Op Prefix Naming Convention (#161)
5e81966 
### Description

Updates `OptimismBaseFeeParams` to use the `Op` prefix naming
convention.

### Metadata

Makes progress on #150.
theochap pushed a commit that referenced this pull request Jan 15, 2026
@refcell
fix: Op Prefix (#164)
16d4ac5 
### Description

Closes #150
theochap pushed a commit that referenced this pull request Jan 21, 2026
@refcell
fix(rpc-types): Op Prefix Naming Convention (alloy-rs/op-alloy#162)
7380fd5 
### Description

Modifies OP Stack types in `rpc-types` to use the `Op` prefix as opposed
to `Optimism` prefix.

### Metadata

Makes progress on #150
theochap pushed a commit that referenced this pull request Jan 21, 2026
@refcell
fix(rpc-types-engine): Op Prefix Naming Convention (alloy-rs/op-alloy…
d59ff68 
…#163)

### Description

Modifies OP Stack types in `rpc-types-engine` to use the `Op` prefix as
opposed to `Optimism` prefix.

### Metadata

Makes progress on #150
theochap pushed a commit that referenced this pull request Jan 21, 2026
@refcell
fix(genesis): Op Prefix Naming Convention (alloy-rs/op-alloy#161)
68496a5 
### Description

Updates `OptimismBaseFeeParams` to use the `Op` prefix naming
convention.

### Metadata

Makes progress on #150.
theochap pushed a commit that referenced this pull request Jan 21, 2026
@refcell
fix: Op Prefix (alloy-rs/op-alloy#164)
6644cc1 
### Description

Closes #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-chain ben-chain ben-chain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@K-Ho @ben-chain