interop,fix: Fix log out-of-range detection.#14973
Merged
1 commit merged intodevelopfrom Mar 21, 2025
Merged
Conversation
ghost
marked this pull request as ready for review
Inphi
approved these changes
Mar 21, 2025
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
LGTM. With this, and the test setup fix, it passes all skipped intra-block test cases.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pull request #14758 we attempted to fix log out of range issues in complete blocks, but working on #14949 has uncovered that the system still isn't handling out-of-range indexes like we want in some situations.
After some digging, I feel like there are some situations where we have a block with no logs and
findLogInfois not returning an error conflict like we want.Moving the check to the
Containsmethod ensures we're returning an ErrConflict in all out-of-range situations.