fix(kurtosis-devnet): correct fallback for user socket#14907
fix(kurtosis-devnet): correct fallback for user socket#14907
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14907 +/- ##
===========================================
- Coverage 46.31% 42.17% -4.15%
===========================================
Files 1126 954 -172
Lines 97513 87316 -10197
===========================================
- Hits 45161 36822 -8339
+ Misses 49074 47384 -1690
+ Partials 3278 3110 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@protolambda I did not pick up the // If the user has configured an override,
// don't change the docker context, client.FromEnv sets up the override already.
if v := os.Getenv(client.EnvOverrideHost); v != "" {
return client.NewClientWithOpts(opts...)
}part in #14908 because the default options are already handled at func (p *defaultDockerProvider) newClient() (dockerClient, error) {
opts := []client.Opt{client.FromEnv}
..., the first line of method. |
But those get overridden by different options, if the global socket happens to exist. The socket may exist, but that shouldn't mean it's the right context to use. A user docker context, like docker-desktop, or alternative external docker instance, should be usable through the standard env-var override. |
|
Closing in behalf of #14911 |
Description
#14884 handled when default docker socket path is not
/var/run/docker.sockand usesclient.ParseHostURL(client.DefaultDockerHost)to check that at this location exists.From docker/docker package,
Since we are using unix socket, we can see
Path: basePathis unpopulated but Host is. Fix to make our devnet-sdk code use Host instead of Path.Tests
Checked local devnet sdk spins up normally.
Additional Context
Fetching proto's diff from #14908