Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ops): Support kona + asterisc in the op-challenger #13198

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Dec 3, 2024

Description

Modifies the op-stack-go dockerfile to add support for kona + asterisc in the op-challenger.

@refcell refcell requested a review from a team as a code owner December 3, 2024 23:24
@refcell refcell requested a review from tynes December 3, 2024 23:24
@refcell refcell self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.67%. Comparing base (5d52959) to head (36eee55).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13198      +/-   ##
===========================================
- Coverage    44.25%   42.67%   -1.58%     
===========================================
  Files          807      751      -56     
  Lines        72707    68042    -4665     
===========================================
- Hits         32173    29035    -3138     
+ Misses       37921    36560    -1361     
+ Partials      2613     2447     -166     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 68 files with indirect coverage changes

@refcell refcell requested review from ajsutton and clabby and removed request for tynes December 3, 2024 23:35
@refcell refcell added C-chore Category: Code, docs or tooling maintenance A-ops Area: ops labels Dec 3, 2024
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally just a few nits.

docker-bake.hcl Outdated Show resolved Hide resolved
ops/docker/op-stack-go/Dockerfile Outdated Show resolved Hide resolved
ops/docker/op-stack-go/Dockerfile Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
@refcell refcell added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit c36de04 Dec 4, 2024
44 checks passed
@refcell refcell deleted the rf/update-op-challenger-with-stage-1-4 branch December 4, 2024 00:14
sigma pushed a commit that referenced this pull request Dec 19, 2024
* chore(ops): add support for the op-challenger to run kona + asterisc

* fix: update docker bake

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ops Area: ops C-chore Category: Code, docs or tooling maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants