Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: op-batcher batch-tx-submitted metric double count #12975

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: op-batcher batch-tx-submitted metric double count #12975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: op-batcher batch-tx-submitted metric double count
  • Loading branch information
@samlaf @geoknee
samlaf authored and geoknee committed Nov 19, 2024
commit 787433734940a421b1195358d8259df8280abc24
2 changes: 1 addition & 1 deletion op-batcher/batcher/channel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (c *channel) TxFailed(id string) {
// TxConfirmed marks a transaction as confirmed on L1. Returns a bool indicating
// whether the channel timed out on chain.
func (c *channel) TxConfirmed(id string, inclusionBlock eth.BlockID) bool {
c.metr.RecordBatchTxSubmitted()
c.metr.RecordBatchTxSuccess()
c.log.Debug("marked transaction as confirmed", "id", id, "block", inclusionBlock)
if _, ok := c.pendingTransactions[id]; !ok {
c.log.Warn("unknown transaction marked as confirmed", "id", id, "block", inclusionBlock)
Expand Down