op-node: Add Metrics #12408
Merged
op-node: Add Metrics #12408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
force-pushed
the
metrics
branch
2 times, most recently
from
2d9d378 to
4b1f84f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12408 +/- ##
===========================================
- Coverage 64.32% 64.14% -0.19%
===========================================
Files 52 52
Lines 4348 4348
===========================================
- Hits 2797 2789 -8
- Misses 1376 1385 +9
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tynes
reviewed
Oct 11, 2024
tynes
reviewed
Oct 11, 2024
tynes
reviewed
Oct 11, 2024
|
These changes are generally good @trianglesphere, thank you. Left a few comments, curious what you think |
trianglesphere
force-pushed
the
metrics
branch
from
4b1f84f to
414e4fb
Compare
|
@tynes I cleaned up some of the logic to avoid duplicating code and simplified the deposit count. Ideally we'd be able to split out each type of txn, but having the deposit vs non deposit split already is a big step forward. |
|
/ci authorize 414e4fb |
|
/ci authorize 4a60f1b |
protolambda
approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Nov 20, 2024
f2056c0
48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds one new metric,
sequencer_activeto report if the sequencer is active or not.This also modifies
transactions_sequenced_total. It is transformed from a Gauge (incorrectly called a counter previously) to a CounterVec. It is labelled withtypewhere the value isl1_info_deposit,deposit, andtxnsto differentiate the different kinds of transactions.