Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Define 64-bit syscalls #12256

Merged
merged 2 commits into from
Oct 2, 2024
Merged

cannon: Define 64-bit syscalls #12256

merged 2 commits into from
Oct 2, 2024

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Oct 2, 2024

SYS_FSTAT on Linux/MIPS64 is equivalent to SYS_FSTAT64 on Linux/MIPS32. So the 64-bit VM similarly emulates SYS_FSTAT as a no-op syscall.

Fixes #12245

Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (40a70bd) to head (697f293).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12256      +/-   ##
===========================================
+ Coverage    71.99%   72.00%   +0.01%     
===========================================
  Files           50       50              
  Lines         3910     3912       +2     
===========================================
+ Hits          2815     2817       +2     
  Misses         910      910              
  Partials       185      185              
Flag Coverage Δ
cannon-go-tests 72.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/arch/arch32.go 100.00% <ø> (ø)
cannon/mipsevm/exec/mips_syscalls.go 92.05% <ø> (ø)
cannon/mipsevm/multithreaded/mips.go 93.96% <100.00%> (+0.03%) ⬆️
cannon/mipsevm/singlethreaded/mips.go 93.24% <100.00%> (ø)

@Inphi Inphi marked this pull request as ready for review October 2, 2024 16:34
@Inphi Inphi requested review from a team as code owners October 2, 2024 16:34
@Inphi Inphi requested review from tynes and mbaxter and removed request for tynes October 2, 2024 16:34
@Inphi Inphi enabled auto-merge October 2, 2024 17:43
@Inphi Inphi added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit 2c7de99 Oct 2, 2024
62 checks passed
@Inphi Inphi deleted the inphi/cannon64-syscalls branch October 2, 2024 17:54
protolambda pushed a commit that referenced this pull request Oct 7, 2024
* cannon: Define 64-bit syscalls

Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon

* update semver-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulate syscalls for Linux/MIPS64
2 participants