Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Reproducible MT-Cannon prestate #12011

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Sep 19, 2024

Updates the make reproducible-prestate script to emit MT-Cannon prestates.

The preimage-reproducibility job isn't yet updated until MT-Cannon is ported to MIPS64.

@Inphi Inphi requested a review from mbaxter September 19, 2024 19:18
@Inphi Inphi requested review from a team as code owners September 19, 2024 19:18
Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving optimistically - just one question about the prestate generation.

op-program/Dockerfile.repro Show resolved Hide resolved
@mbaxter
Copy link
Contributor

mbaxter commented Sep 19, 2024

The preimage-reproducibility job isn't yet updated until MT-Cannon is ported to MIPS64.

This comment is referencing this job? We should make an issue for this to make sure we come back to it.

@Inphi
Copy link
Contributor Author

Inphi commented Sep 19, 2024

The preimage-reproducibility job isn't yet updated until MT-Cannon is ported to MIPS64.

This comment is referencing this job? We should make an issue for this to make sure we come back to it.

We can do this later, once I figure out a home for the 64-bit board

@Inphi Inphi added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit 54ae1e4 Sep 19, 2024
60 of 62 checks passed
@Inphi Inphi deleted the inphi/mt-reproducible-prestate branch September 19, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants