op-e2e: Organize e2e system tests in subdirs #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Sep 17, 2024
ajsutton
approved these changes
Sep 17, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* op-e2e: organize system tests * op-e2e: update CI make targets * op-e2e: fix artifacts file paths * op-e2e: Fix paths. * op-e2e: Fix paths again --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This organizes the op-e2e system tests (the ones using the old
System/SystemConfiginto sub-dirs within asystempackage.The engine-only system tests went into a new
op-e2e/opgethpackage. This includes fastlz, because the fastlz depend on the same engine setup (at some point we can clean that up).The
System/SystemConfigitself are in the newop-e2e/system/e2esyspackage.The e2e
InitParallel/ conditional-test helpers are still in the root of the e2e package.Each of the
systempackages has its ownTestMainthat callsop_e2e.RunMain, so we can still apply global setting changes where necessary (like in the external-EL mode).I split the mega
system_test.gointo smaller files, categorized into the subdirs based on their function.Helper functions for transactions went into
op-e2e/system/helperspackage. These can move toe2eutilsonce we remove theSystemConfig/Systemspecific parts about them.Tests
Organizes tests. No new / removed tests.