Port deployers, add end-to-end contract deployments #11922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
requested review from
mbaxter and
protolambda
and removed request for
a team
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
mslipper
force-pushed
the
feat/op-deployer-3
branch
3 times, most recently
from
4f77209
to
5225f0b
Compare
protolambda
reviewed
Sep 16, 2024
mslipper
force-pushed
the
feat/op-deployer-2
branch
from
79c8175
to
fc17d90
Compare
mslipper
force-pushed
the
feat/op-deployer-3
branch
from
5225f0b
to
80b0696
Compare
mslipper
force-pushed
the
feat/op-deployer-2
branch
from
fc17d90
to
80aba90
Compare
mslipper
force-pushed
the
feat/op-deployer-3
branch
from
80b0696
to
ee160a1
Compare
mslipper
force-pushed
the
feat/op-deployer-2
branch
3 times, most recently
from
046ea40
to
c55f83c
Compare
mslipper
force-pushed
the
feat/op-deployer-3
branch
2 times, most recently
from
40842e1
to
1293323
Compare
mslipper
force-pushed
the
feat/op-deployer-3
branch
from
1293323
to
6578220
Compare
This PR ports over the deployers in `interopgen` into `op-deployer`, and updates `op-deployer` to support end-to end contract deployments for both the Superchain and individual OP Chains. This PR includes a couple of bugfixes for things I discovered along the way: 1. The script host is updated to bump the nonce of the address calling the CREATE2 deployer when broadcasting. This fixes a chain/simulation mismatch that blocked contracts from being deployed. 2. The DeployImplementations contract used a fixed CREATE2 salt, which caused problems on repeated deployments. I updated the contract to pull the nonce from the environment as we do elsewhere. Builds on #11910.
mslipper
force-pushed
the
feat/op-deployer-3
branch
from
6578220
to
9f0eb73
Compare
protolambda
reviewed
Sep 16, 2024
protolambda
approved these changes
Sep 16, 2024
mbaxter
approved these changes
Sep 16, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…m#11922) This PR ports over the deployers in `interopgen` into `op-deployer`, and updates `op-deployer` to support end-to end contract deployments for both the Superchain and individual OP Chains. This PR includes a couple of bugfixes for things I discovered along the way: 1. The script host is updated to bump the nonce of the address calling the CREATE2 deployer when broadcasting. This fixes a chain/simulation mismatch that blocked contracts from being deployed. 2. The DeployImplementations contract used a fixed CREATE2 salt, which caused problems on repeated deployments. I updated the contract to pull the nonce from the environment as we do elsewhere. Builds on ethereum-optimism#11910.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over the deployers in
interopgenintoop-deployer, and updatesop-deployerto support end-to end contract deployments for both the Superchain and individual OP Chains.This PR includes a couple of bugfixes for things I discovered along the way:
Builds on #11910.