Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt-da: remove unused error handling #11828

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −6
Open

alt-da: remove unused error handling #11828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd564ed
remove unused error handling
qzhodl Sep 10, 2024
3829aad
Merge branch 'ethereum-optimism:develop' into develop
qzhodl Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions op-node/rollup/derive/altda_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,8 @@ func (s *AltDADataSource) Next(ctx context.Context) (eth.Data, error) {
}
// use the commitment to fetch the input from the AltDA provider.
data, err := s.fetcher.GetInput(ctx, s.l1, s.comm, s.id)
// GetInput may call for a reorg if the pipeline is stalled and the AltDA manager
// continued syncing origins detached from the pipeline origin.
if errors.Is(err, altda.ErrReorgRequired) {
// challenge for a new previously derived commitment expired.
return nil, NewResetError(err)
} else if errors.Is(err, altda.ErrExpiredChallenge) {

if errors.Is(err, altda.ErrExpiredChallenge) {
// this commitment was challenged and the challenge expired.
s.log.Warn("challenge expired, skipping batch", "comm", s.comm)
s.comm = nil
Expand Down