Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Autodetect VM type from state #11803

Merged
merged 13 commits into from
Sep 10, 2024

op-challenger: Update canon state loading test to cover multiple stat…

1dd1668
Select commit
Loading
Failed to load commit list.
Merged

cannon: Autodetect VM type from state #11803

op-challenger: Update canon state loading test to cover multiple stat…
1dd1668
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 0s

78.47% (+0.34%) compared to f64d817

View this Pull Request on Codecov

78.47% (+0.34%) compared to f64d817

Details

Codecov Report

Attention: Patch coverage is 68.35443% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (f64d817) to head (1dd1668).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
cannon/mipsevm/versions/state.go 66.07% 14 Missing and 5 partials ⚠️
cannon/mipsevm/multithreaded/state.go 0.00% 3 Missing ⚠️
cannon/mipsevm/singlethreaded/state.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11803      +/-   ##
===========================================
+ Coverage    78.13%   78.47%   +0.34%     
===========================================
  Files           40       41       +1     
  Lines         3179     3206      +27     
===========================================
+ Hits          2484     2516      +32     
+ Misses         533      529       -4     
+ Partials       162      161       -1     
Files with missing lines Coverage Δ
cannon/mipsevm/exec/stack.go 66.66% <100.00%> (ø)
cannon/mipsevm/multithreaded/instrumented.go 68.57% <100.00%> (+5.41%) ⬆️
cannon/mipsevm/multithreaded/stack.go 73.07% <100.00%> (ø)
cannon/mipsevm/program/metadata.go 53.84% <100.00%> (ø)
cannon/mipsevm/singlethreaded/instrumented.go 64.78% <100.00%> (+5.04%) ⬆️
cannon/mipsevm/tests/helpers.go 100.00% <100.00%> (ø)
cannon/serialize/binary.go 36.84% <100.00%> (ø)
cannon/serialize/detect.go 100.00% <100.00%> (ø)
cannon/mipsevm/multithreaded/state.go 56.45% <0.00%> (+1.33%) ⬆️
cannon/mipsevm/singlethreaded/state.go 55.39% <0.00%> (+1.58%) ⬆️
... and 1 more