Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: local devnet #11590

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Interop: local devnet #11590

merged 22 commits into from
Oct 31, 2024

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Aug 23, 2024

Description

Local docker-compose to run an interop devnet.

Builds on top of #11589

TODO:

  • implement CLI around interopgen package to build the genesis / config data needed
  • adapt docker compose or entry-points, to configure sequencer/proposer/batcher/etc. keys using interop devkeys package. generate env files with keys retrieved from devkey CLI.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Metadata

Fix #11306

@protolambda protolambda self-assigned this Aug 23, 2024
@protolambda protolambda added this to the Interop: Devnet 1 milestone Aug 23, 2024
Copy link
Contributor

semgrep-app bot commented Aug 23, 2024

Semgrep found 3 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/scripts/Artifacts.s.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 30 port-all-interfaces findings:

Service port is exposed on all interfaces

Ignore this finding from port-all-interfaces.

@protolambda
Copy link
Contributor Author

Ready for review, but do not merge yet, as this is stacked on top of the interop-gen PR, which is not in a state where it can be merged into develop yet (due to pre-OPSM deploy workarounds).

axelKingsley
axelKingsley previously approved these changes Aug 26, 2024
Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Left optimistic Approval based on - did you run this locally? I assume so, and I assume it created the appropriate entities.

interop-devnet/docker-compose.yml Show resolved Hide resolved
@protolambda protolambda requested a review from a team as a code owner August 28, 2024 18:07
@protolambda protolambda requested review from smartcontracts and removed request for a team August 28, 2024 18:07
@protolambda protolambda changed the base branch from interopgen to interopgen2 September 10, 2024 19:55
@protolambda protolambda requested a review from a team as a code owner September 10, 2024 19:55
@protolambda protolambda requested review from bitwiseguy and removed request for a team, smartcontracts and 0x00101010 September 10, 2024 19:55
@axelKingsley
Copy link
Contributor

On the latest runs, I see Unsafe, Safe and Finalized update when and as needed. Recent clean runs have connected without issue and make the progress expected from the network. On occasion I've seen issues where the Finalized head can't be fetched from the Supervisor, but I believe the latest fixes have eliminated this.

@axelKingsley axelKingsley added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@axelKingsley axelKingsley added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@axelKingsley axelKingsley added this pull request to the merge queue Oct 31, 2024
Merged via the queue into develop with commit 7f941b8 Oct 31, 2024
48 checks passed
@axelKingsley axelKingsley deleted the interop-local branch October 31, 2024 16:28
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
* local interop devnet

* interop-devnet: experimental op-geth docker image, connect with op-supervisor

* interop-devnet: port and path fixes

* interop-devnet: datadir fix

* interop-local: more fixes

* interop-devnet: connect op-supervisor to L2 EL nodes using RPC

* more fixes

* ops-bedrock: fix l2 op geth dockerfile for interop

* interop-devnet: fix supervisor RPC add workaround

* interop-devnet: implement review suggestions

* fixes from run-testing

* Add op-deployer to dockerignore exceptions

* use latest geth rc

* use RW Locks in Update Functions

* add log for new cross-safe head

* make updates much more frequent

* use LocalDB for LastDerivedFrom

* Add log message for finalization update

* op-supervisor: fix db locking, fix crossdb usage

* interop-devnet: use chain IDs as chain indices, since it's not translated everywhere yet

* op-supervisor: cross-derived-from RPC method

* Work Process ErrFuture to Debug Log

---------

Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-do-not-merge Meta: Do not merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Interop: local devnet
3 participants