Skip to content

Remove "to" field override in getLogs#113

Merged
karlfloersch merged 1 commit intomasterfrom
Hotfix/GetLogsToFieldFix
Apr 28, 2020
Merged

Remove "to" field override in getLogs#113
karlfloersch merged 1 commit intomasterfrom
Hotfix/GetLogsToFieldFix

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Apr 28, 2020

Description

Fixes bugs with Synthetix getLogs - full credit to @ben-chain !!

Contributing Agreement

@K-Ho K-Ho requested a review from karlfloersch April 28, 2020 02:09
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const receipt = await this.getTransactionReceipt(transaction.hash)
transaction['to'] = receipt.contractAddress
}
logItem['address'] = transaction['to']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

@karlfloersch karlfloersch merged commit 2ca62fb into master Apr 28, 2020
karlfloersch added a commit that referenced this pull request Apr 28, 2020
masonforest pushed a commit that referenced this pull request Apr 28, 2020
karlfloersch added a commit that referenced this pull request Apr 28, 2020
@K-Ho K-Ho deleted the Hotfix/GetLogsToFieldFix branch May 13, 2020 21:19
snario pushed a commit that referenced this pull request Apr 14, 2021
* Testing out deployment changes

* Add nonce fix

* Linted files
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants