-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts: update deploy script to read from superchain-registry toml configs #11175
base: develop
Are you sure you want to change the base?
Conversation
@@ -81,6 +85,28 @@ abstract contract Artifacts { | |||
} | |||
} | |||
|
|||
function hasSuffix(string memory _fullString, string memory _suffix) public pure returns (bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @tynes: We should see if solady has a helper here for this so we don't need to implement/test our own code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11175 +/- ##
============================================
- Coverage 60.69% 16.44% -44.25%
============================================
Files 20 8 -12
Lines 1781 535 -1246
Branches 71 71
============================================
- Hits 1081 88 -993
+ Misses 667 447 -220
+ Partials 33 0 -33
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Description
The current
contracts-bedrock
deploy script is able to read contract addresses from json files located in the local file system. This PR updates the deploy script such that a developer can also point to one of the newsuperchain-registry/superchain/config
.toml files and the script can pull addresses from there. The code will remain backwards compatible with the old json address files.Tests
None yet