Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: update deploy script to read from superchain-registry toml configs #11175

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bitwiseguy
Copy link
Contributor

Description

The current contracts-bedrock deploy script is able to read contract addresses from json files located in the local file system. This PR updates the deploy script such that a developer can also point to one of the new superchain-registry/superchain/config .toml files and the script can pull addresses from there. The code will remain backwards compatible with the old json address files.

Tests

None yet

@@ -81,6 +85,28 @@ abstract contract Artifacts {
}
}

function hasSuffix(string memory _fullString, string memory _suffix) public pure returns (bool) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @tynes: We should see if solady has a helper here for this so we don't need to implement/test our own code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.44%. Comparing base (c55ade0) to head (32bd495).
Report is 358 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (c55ade0) and HEAD (32bd495). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c55ade0) HEAD (32bd495)
cannon-go-tests 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11175       +/-   ##
============================================
- Coverage    60.69%   16.44%   -44.25%     
============================================
  Files           20        8       -12     
  Lines         1781      535     -1246     
  Branches        71       71               
============================================
- Hits          1081       88      -993     
+ Misses         667      447      -220     
+ Partials        33        0       -33     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests 27.14% <ø> (ø)
sdk-tests 16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 10, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 25, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants