-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-challenger: clarify the output #11141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These longer names aren't currently reflected din the lineFormat
above to ensure the columns line up. The names are deliberately quite succinct to keep the output to a reasonable line length so it can display well in most terminals so I'd rather not increase them. You need a pretty good understanding of dispute games to be able to understand this output anyway.
Also not sure why spaces in titles are being replaced by _
.
The reason for adding the hyphen is that without it, attributes with spaces in the middle can easily be misunderstood as two separate attributes rather than one whole attribute. As for the alignment, the arrangement on my CLI is basically the same as before, so there shouldn't be any misalignment. As shown in the picture. @ajsutton |
ah yeah I can see the new names still fit within the allocated space so the line format doesn't need changing. I'm definitely not a fan of adding in underscores - they just add more visual clutter. I'd also keep I would also suggest just using |
Make sense. updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
6f887d5
For my first time to use
./bin/op-challenger list-claims
The data name really confuses me, after I check the spces, I found the index means for Trace_Index, we should clarify it. And the parent for the root shouldn't be
NIL
, Because of the missing data, I mistakenly thought thatParent Depth
was a whole data, not two data.