chore: disallow specify both --p2p.static and --p2p.disable
#10963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
opt_p2p_check
branch
from
4f7bc3a
to
4b5bb5d
Compare
tynes
approved these changes
Jun 25, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Jun 28, 2024
d8f85c8
58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--p2p.staticis useful when adding more rollup nodes. This PR tries to report an error when user specified both--p2p.staticand--p2p.disableby mistake.