op-node: remove unnecessary cgo binding in tests#10825
op-node: remove unnecessary cgo binding in tests#10825sebastianst merged 1 commit intoethereum-optimism:developfrom
Conversation
|
@sebastianst I think you probably have the most context on whether we need a specific zstd library or not for this test, can you take a look. I thought we had cgo dependencies via things like op-geth anyway to be honest, but not sure. |
As my experience, using cgo unnecessarily complicates whole project. It's best to avoid it as much as possible. |
|
It may well be unavoidable for some of the precompile dependencies on the execution side. |
There was a problem hiding this comment.
@ajsutton the switch is fine here, because this is just a test for invalid compression anyways
Description
remove unnecessary cgo binding in test.
Additional context
cgo makes build more complicated and disable cross-compile.
I think it is not good idea using cgo binding without any discussion.
Metadata
#10750
#10358
https://dave.cheney.net/2016/01/18/cgo-is-not-go
dgraph-io/badger#1162 - Use pure Go zstd implementation