op-challenger: Fix highest_acted_l1_block metric

[ajsutton]

Description

Completed games weren't updating their latest acted block because they don't get scheduled which meant the metric always reported 0.

Tests

Updated unit tests.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve updating the handling and tracking of block numbers in a gaming scheduler system. Specifically, after a game completes, the last processed block number is now assigned in the coordinator.go file. Additionally, the test in coordinator_test.go reflects an updated assertion to match the new logic for recording block numbers after game completion.

Changes

File Path	Change Summary
.../scheduler/coordinator.go	Added assignment of state.lastProcessedBlockNum under specific game status conditions.
.../scheduler/coordinator_test.go	Updated metric recording and test assertion to reflect changes in block number handling after game ends.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4dc6aa8 and 73c6fc1.

Files selected for processing (2)

• op-challenger/game/scheduler/coordinator.go (1 hunks)
• op-challenger/game/scheduler/coordinator_test.go (1 hunks)

Additional comments not posted (2)

op-challenger/game/scheduler/coordinator.go (1)

149-149: The update to lastProcessedBlockNum for non-in-progress games ensures that metrics are accurately reported. This change aligns with the PR's objective to fix metric reporting issues.

Verification successful

---

The verification process has successfully identified multiple usages of lastProcessedBlockNum within the coordinator.go file in the op-challenger/game/scheduler/ directory. Here are the key points from the findings:

1. lastProcessedBlockNum is declared as a uint64.
2. It is used to set the lowestProcessedBlockNum in a comparison operation, which suggests its role in tracking the range of processed blocks.
3. It is initialized in a gameState struct with the value of c.lastScheduledBlockNum.
4. It is directly set to blockNumber and j.block in different parts of the code.

These usages indicate that lastProcessedBlockNum is a critical variable for tracking the progress of game states in terms of block processing. The update to this variable in the context of non-in-progress games, as seen in the PR, seems to be consistent with its role in the system. There is no indication from the current findings that this update adversely affects other functionalities.

Final Assessment:
The update to lastProcessedBlockNum for non-in-progress games ensures that metrics are accurately reported and aligns with the PR's objective to fix metric reporting issues. The verification has not revealed any adverse effects on other functionalities.

• The variable is crucial for tracking block processing and is used consistently across the coordinator.go file.
• The change is localized and does not interfere with other parts of the system based on the current code usage.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the update to `lastProcessedBlockNum` does not affect other functionalities.

# Test: Search for other usages of `lastProcessedBlockNum`. Expect: No adverse effects on other functionalities.
rg --type go 'lastProcessedBlockNum' src/op-challenger/game/scheduler/

Length of output: 144

---

---

Script:

#!/bin/bash
# Description: Find the correct path for the 'scheduler' directory and verify the usage of 'lastProcessedBlockNum'.

# Step 1: Find the correct path for the 'scheduler' directory.
fd 'scheduler' --type d

# Step 2: If the correct path is found, search for 'lastProcessedBlockNum' within that directory.
fd 'scheduler' --type d --exec rg 'lastProcessedBlockNum' {}

Length of output: 612

op-challenger/game/scheduler/coordinator_test.go (1)

229-229: The update in the test expectation from 1 to 2 for actedL1Blocks correctly reflects the changes made to the metric's updating logic in the main code. This ensures that the test remains valid and effective.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.