Fix makefile fuzz targets on osx

[Inphi]

Go fuzz tests fail to build due to a bug in the recent Apple linker. ref: golang/go#65169.

To fix we revert to using the old linker via -ld_classic. This relies on xcode 15 and above as the -ld_classic flag was introduced then.

[coderabbitai]

Walkthrough

Walkthrough

The updates across various Makefiles introduce a conditional block to set FUZZLDFLAGS for macOS, particularly addressing issues with the old Apple linker. This variable is then utilized in the fuzz target of each Makefile to modify the go test commands, ensuring compatibility and addressing potential issues with Xcode.

Changes

Files	Summary of Changes
cannon/Makefile	Added conditional block for FUZZLDFLAGS and updated fuzz target to include these flags in go test commands.
op-batcher/Makefile	Introduced FUZZLDFLAGS for macOS in fuzz target without altering declarations of exported entities.
op-chain-ops/..., op-challenger/..., op-node/..., op-service/...	Similar changes: Added FUZZLDFLAGS and modified fuzz target to include these flags in go test commands, addressing issues with old Apple linker on macOS.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f2e06c3 and 75d0ba4.

Files selected for processing (6)

• cannon/Makefile (2 hunks)
• op-batcher/Makefile (2 hunks)
• op-chain-ops/Makefile (2 hunks)
• op-challenger/Makefile (1 hunks)
• op-node/Makefile (2 hunks)
• op-service/Makefile (1 hunks)

Files not reviewed due to errors (3)

• cannon/Makefile (no review received)
• op-batcher/Makefile (no review received)
• op-node/Makefile (no review received)

Additional comments not posted (6)

op-challenger/Makefile (2)

10-13: Properly added conditional for Darwin systems to address the linker issue.

---

19-19: Correctly modified fuzz target to include FUZZLDFLAGS in the go test command.

op-chain-ops/Makefile (2)

1-4: Properly added conditional for Darwin systems to address the linker issue.

---

22-25: Correctly modified fuzz target to include FUZZLDFLAGS in multiple go test commands.

op-service/Makefile (2)

1-4: Properly added conditional for Darwin systems to address the linker issue.

---

13-20: Correctly modified fuzz target to include FUZZLDFLAGS in multiple go test commands.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mbaxter]

looks good - thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (1c33c39) to head (75d0ba4).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10476       +/-   ##
============================================
+ Coverage    42.31%   81.59%   +39.28%     
============================================
  Files           73       10       -63     
  Lines         4838     1081     -3757     
  Branches       766        0      -766     
============================================
- Hits          2047      882     -1165     
+ Misses        2682      165     -2517     
+ Partials       109       34       -75     

Flag	Coverage Δ
cannon-go-tests	81.59% <ø> (ø)
chain-mon-tests	?
common-ts-tests	?
contracts-ts-tests	?
core-utils-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes