Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts, l2geth): native ETH value support for ovmCALL #1038

Merged
merged 22 commits into from
Jun 10, 2021
Merged

feat(contracts, l2geth): native ETH value support for ovmCALL #1038

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d46d449
feat(contracts): add ovmCALL-types with native value
ben-chain May 26, 2021
94bd4b3
test(integration-tests): ovmCALL-types with value (compiler and wrapper)
ben-chain May 27, 2021
47a4f38
fix(contracts): account for intrinsic gas of OVM_ETH sends
ben-chain Jun 2, 2021
1b7150d
fix(contracts): merge conflict bug
smartcontracts Jun 2, 2021
37bc9b8
fix(contracts): update gas benchmark
smartcontracts Jun 2, 2021
897c7a7
feat(contracts, integration-tests): use new value-compatible compiler
ben-chain Jun 2, 2021
1397cda
feat(contracts,l2geth): support value calls in OVM_ECDSAContractAccount
ben-chain Jun 2, 2021
104d823
fix(contracts): ovmDELEGATECALL does not change message context
ben-chain Jun 4, 2021
760a2a7
feat(contracts): sending value between EOAs
ben-chain Jun 8, 2021
b4fb7ac
test(integration-tests): ovmDELEGATECALL preserves ovmCALLVALUE
ben-chain Jun 8, 2021
4c10635
test(integration-tests): assert ovmSELFBALANCEs correct
ben-chain Jun 8, 2021
f50151a
test(integration-tests): intrinsic gas for eth value calls
ben-chain Jun 8, 2021
fee1f3d
test(integration-tests): update gas values
ben-chain Jun 8, 2021
ed92d53
chore(contracts): lint
ben-chain Jun 8, 2021
b6b8275
feat(contracts, l2geth): eth_calls with nonzero value
ben-chain Jun 8, 2021
97c4231
chore: minor fixups and comments based on PR feedback
ben-chain Jun 9, 2021
f88da35
test(integration-tests): add requested tests from PR reviews
ben-chain Jun 9, 2021
0c802d5
test(integration-tests): ovmSELFBALANCE is preserved in ovmDELEGATECALLs
ben-chain Jun 9, 2021
edc8cbd
fix(contracts): fix bug where ovmDELEGATECALL could fail if balance w…
ben-chain Jun 10, 2021
9dcecd8
chore: add changeset
ben-chain Jun 10, 2021
4c02ee3
fix(contracts): update intrinsic gas for worst-case value sends
ben-chain Jun 10, 2021
3dc67db
chore: address final PR nits/improvements
ben-chain Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add changeset
  • Loading branch information
@ben-chain
ben-chain committed Jun 10, 2021
commit 9dcecd83899fddab493d5355bb0e45c0d8b099e1
7 changes: 7 additions & 0 deletions .changeset/quiet-ladybugs-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@eth-optimism/integration-tests': minor
'@eth-optimism/l2geth': minor
'@eth-optimism/contracts': minor
---

Add support for ovmCALL with nonzero ETH value