op-batcher: Always use recent block from startup tx check

[sebastianst]

Description

Changes the startup recent-tx-check to always use the returned block number by the check, also in the case that no recent tx was found. If we don't find a recent batcher transaction, we can safely wait for the node to sync to that oldest checked block, which will be quicker than waiting for it to sync to the current head.

Tests

The underlying recent tx and node syncing functions are tested. This is just changing how they're tied together and we don't test this yet.

Additional context

This shortcut is actually the reason why we implemented recent tx checking.

[coderabbitai]

Walkthrough

Walkthrough

The recent update involves adjustments to the logging mechanism within the BatchSubmitter struct in the driver.go file. The modifications enhance error messaging and logging for transactions on Layer 1 (L1). Additionally, there's a strategic change in the sequence of operations, specifically moving the assignment of l1TargetBlock to occur after error checks.

Changes

File	Summary of Changes
.../batcher/driver.go	Refined error logging for L1 transactions; repositioned l1TargetBlock assignment post-error handling.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 613e5dc and a1f341a.

Files selected for processing (1)

• op-batcher/batcher/driver.go (1 hunks)

Additional comments not posted (1)

op-batcher/batcher/driver.go (1)

360-362: Enhance logging for transaction checks.

The added logging for checking recent batcher transactions on L1 provides valuable information about the transaction check process, including the head of L1, the most recent block checked, and whether it was found. This should greatly aid in monitoring and debugging.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[axelKingsley]

Looks good, I'll summarize to confirm it does what I think: This change makes it so that after a look-behind on startup, the sync-wait now targets the earliest block in the look-behind, because we already know no batches will be discovered on those blocks.