Skip to content

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Apr 22, 2024

Description

Adds a daily job in CI to rebuild specific versions of op-program and confirm the build is still reproducible.

This doesn't verify that the current develop is reproducible. Unfortunately circleci caching the docker build so trying to build it twice just uses the cache the second time and doesn't actually test anything. Since we don't know what the expected hash should be until we build it there's not much we can do to verify reproducibility of the latest version.

Metadata

@semgrep-app
Copy link
Contributor

semgrep-app bot commented Apr 22, 2024

Semgrep found 1 dangerous-exec-command finding:

  • op-challenger/game/fault/trace/cannon/executor.go

Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.

Ignore this finding from dangerous-exec-command.

@ajsutton ajsutton force-pushed the aj/reproducibility-check branch from 61cd468 to 224f3fe Compare April 22, 2024 04:44
@ajsutton ajsutton force-pushed the aj/reproducibility-check branch from 332b73c to ebe13a5 Compare April 22, 2024 04:46
@ajsutton ajsutton marked this pull request as ready for review April 22, 2024 20:50
@ajsutton ajsutton requested a review from a team as a code owner April 22, 2024 20:50
@ajsutton ajsutton requested a review from protolambda April 22, 2024 20:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Walkthrough

Walkthrough

The update introduces a new parameter reproducibility_dispatch to control the triggering of a job focused on enhancing reproducibility. A new job, preimage-reproducibility, has been added to build and verify prestate hashes. Additionally, a scheduled workflow named scheduled-preimage-reproducibility has been implemented to run periodically based on the reproducibility_dispatch parameter.

Changes

File Path Change Summary
.circleci/config.yml - Added reproducibility_dispatch parameter (default: false).
- Added preimage-reproducibility job.
- Added scheduled-preimage-reproducibility workflow.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3fc229e and dea091e.
Files selected for processing (1)
  • .circleci/config.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .circleci/config.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@ajsutton ajsutton force-pushed the aj/reproducibility-check branch from c37e11c to dea091e Compare April 22, 2024 21:06
@ajsutton ajsutton requested review from refcell and removed request for protolambda April 22, 2024 22:13
@trianglesphere trianglesphere added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@ajsutton ajsutton added this pull request to the merge queue Apr 23, 2024
Merged via the queue into develop with commit c651859 Apr 23, 2024
@ajsutton ajsutton deleted the aj/reproducibility-check branch April 23, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants