Skip to content

Commit

Permalink
Update expectRevert reason in OptimismPortalKontrol & bump Kontro…
Browse files Browse the repository at this point in the history
…l version (#10159)

* versions.json: bump Kontrol from `0.1.196` to `0.1.247`

* OptimismPortal.k.sol: update `expectRevert` reasons
  • Loading branch information
JuanCoRo authored Apr 16, 2024
1 parent f0d68b0 commit fa19f9a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
IOptimismPortal as OptimismPortal,
ISuperchainConfig as SuperchainConfig
} from "./interfaces/KontrolInterfaces.sol";
import "src/libraries/PortalErrors.sol";

contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
OptimismPortal optimismPortal;
Expand All @@ -27,7 +28,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
vm.prank(optimismPortal.guardian());
superchainConfig.pause("identifier");

vm.expectRevert("OptimismPortal: paused");
// We need to encode the error selector as bytes instead of bytes4 because the bytes4 signature
// it's not currently supported
// Tracking issue: https://github.com/runtimeverification/kontrol/issues/466
vm.expectRevert(abi.encodeWithSelector(CallPaused.selector));
optimismPortal.finalizeWithdrawalTransaction(_tx);
}

Expand All @@ -48,7 +52,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
vm.prank(optimismPortal.guardian());
superchainConfig.pause("identifier");

vm.expectRevert("OptimismPortal: paused");
// We need to encode the error selector as bytes instead of bytes4 because the bytes4 signature
// it's not currently supported
// Tracking issue: https://github.com/runtimeverification/kontrol/issues/466
vm.expectRevert(abi.encodeWithSelector(CallPaused.selector));
optimismPortal.proveWithdrawalTransaction(_tx, _l2OutputIndex, _outputRootProof, _withdrawalProof);
}

Expand Down
2 changes: 1 addition & 1 deletion versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"geth": "v1.13.14",
"nvm": "v20.9.0",
"slither": "0.10.0",
"kontrol": "0.1.196"
"kontrol": "0.1.247"
}

0 comments on commit fa19f9a

Please sign in to comment.