This repository was archived by the owner on Dec 12, 2023. It is now read-only.
feat(AttestationStation): Simple tutorial #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbvegan
reviewed
Nov 3, 2022
There was a problem hiding this comment.
The tutorial in the README is great! I tested it on optimism goerli and it worked without a hitch. I left some comments on the other scripts and test file. They can probably be removed. If we want to keep them, we should run some clean up and add missing dependencies. One other general thing, I think the directory should be renamed from SocialContract to social-contract for consistency.
ecosystem/SocialContract/README.md
Outdated
| attestation = { | ||
| about: goatAddr, | ||
| key: educationKey, | ||
| val: ethers.utils.toUtf8Bytes("Ate a geometry textbook") |
There was a problem hiding this comment.
For consistency, maybe we should pull the value into its own variable too
There was a problem hiding this comment.
The other values are in variables because they are used multiple times. This value is only used once.
Rename Social Contract to AttestationStation
qbzzt
changed the title
smartcontracts
approved these changes
Nov 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing: https://linear.app/optimism/issue/DOCS-695/create-tutorial-for-social-contract-attestations