Isthmus: re-introduce withdrawals root in block header #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a7e2bc5.
vdamle
force-pushed
the
l2-withdrawals-root-new
branch
from
65a129d to
cf1bdd0
Compare
protolambda
approved these changes
Dec 16, 2024
|
Will confirm with @sebastianst if we can merge this now. |
sebastianst
approved these changes
Dec 16, 2024
* Adds a `BlockType` interface with a method to check if the header has a CustomWithdrawalsRoot, to be used when Isthmus fork is active. * `ChainConfig` implements the interface and is passed to NewBlock() api. * `BlockConfig` implements the interface as well and is used for invocation from tests.
vdamle
force-pushed
the
l2-withdrawals-root-new
branch
from
cf1bdd0 to
a55434e
Compare
protolambda
approved these changes
Dec 16, 2024
vdamle
commented
Dec 16, 2024
|
Merging with a merge-commit, to keep the re-apply commit in there, since it undoes a revert. |
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores the changes originally in #383. We had to revert this to de-risk Holocene RC. This PR re-introduces the changes for L2 withdrawals root. An additional change was added to do away passing the
ChainConfigdirectly toNewBlock()and instead pass aBlockTypeinterface that is implement d byChainConfig. An additionalBlockConfigstruct implements the interface as well, for usage in tests here and in the monorepo.Tests
Additional context
Original PR for this: #383
Reverted changes: #449
Metadata
Ref: ethereum-optimism/optimism#12044