Skip to content

miner: remove tcount adding after miner.commitTransaction #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

miner: remove tcount adding after miner.commitTransaction #419

merged 2 commits into from
Nov 6, 2024

Conversation

islishude
Copy link
Contributor

miner.commitTransaction adds the tcount internally

Seems that geth updated the code, but op-geth didn't notice the change.

ethereum/go-ethereum#28623

@islishude islishude requested a review from a team as a code owner October 29, 2024 10:50
@islishude islishude requested a review from ajsutton October 29, 2024 10:50
@islishude islishude changed the title miner: add tcount incorrectly miner: remove tcount adding after miner.commitTransaction Oct 30, 2024
@ajsutton ajsutton merged commit 0891f5a into ethereum-optimism:optimism Nov 6, 2024
4 of 6 checks passed
@islishude islishude deleted the patch-1 branch November 7, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants