Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Holocene fork references #357

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add Holocene fork references #357

merged 2 commits into from
Aug 12, 2024

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Aug 6, 2024

Description

  • Updates SCR to pull in new Holocene fork field.
  • Adds Holocene fork references in various places.

Additional context

Part of Holocene prep

@sebastianst sebastianst requested a review from a team as a code owner August 6, 2024 20:35
@sebastianst sebastianst requested a review from ajsutton August 6, 2024 20:35
@sebastianst sebastianst changed the title Add Holocene fork references & update SCR for Granite mainnet activation Add Holocene fork references Aug 6, 2024
Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes have strong prior-art so I was able to confirm that the Holocene changes match in all cases with the treatment of other Hard Forks. In particular I confirmed that no Copy/Paste errors misnamed any lines.

All mechanical changes appear correct. I wonder if someday we could automate this.

cmd/utils/flags.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
params/config.go Show resolved Hide resolved
@sebastianst sebastianst enabled auto-merge (squash) August 12, 2024 20:44
@sebastianst sebastianst merged commit f561467 into optimism Aug 12, 2024
9 of 10 checks passed
@sebastianst sebastianst deleted the seb/prep-holocene branch August 12, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants