Make OptimismConfig.EIP1559DenominatorCanyon optional #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
reviewed
Jul 8, 2024
bitwiseguy
commented
Jul 8, 2024
sebastianst
reviewed
Jul 8, 2024
bitwiseguy
commented
Jul 8, 2024
sebastianst
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the
OptimismConfig.EIP1559DenominatorCanyonfield was required, so when Unmarshaled from a json file in the superchain-registry, it was populated with the default0value if it was missing.This PR makes that field optional, so that it is initialized as
nil, and only populated if it is present in the json file. This allows the new superchain-registryadd-chain check-genesiscommand to be backwards compatible with chains that did not have canyon activated at genesis.Additional context
add-chain check-genesiscommand: add-chain: add check-genesis subcommand superchain-registry#354