Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic fma: improve #131

Merged
merged 5 commits into from
Oct 17, 2024
Merged

generic fma: improve #131

merged 5 commits into from
Oct 17, 2024

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Oct 10, 2024 •
edited
Loading

  • Adds information about detection of head stalls
  • Rearranges and dedupes content around failure modes causing a chain split versus those that do not
  • Adds action items, these are the main value of the FMA process.

@geoknee geoknee mentioned this pull request Oct 10, 2024
Open
@geoknee geoknee changed the title generic fma: add note about alerting for chain head stalls generic fma: improve Oct 11, 2024
sebastianst
sebastianst approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for improving, just minor nits.

security/fma-generic-hardfork.md Outdated Show resolved Hide resolved
security/fma-generic-hardfork.md Outdated Show resolved Hide resolved
geoknee and others added 2 commits October 17, 2024 10:30
@geoknee @sebastianst
Apply suggestions from code review
61ec521 
Co-authored-by: Sebastian Stammler <stammler.s@gmail.com>
@geoknee
remove emergency release recovery mechanism
e1c4947
@geoknee geoknee merged commit 2b7d55d into main Oct 17, 2024
@geoknee geoknee deleted the gk/generic-fma-improvements branch October 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianst sebastianst sebastianst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoknee @sebastianst