feat: Add FMA superchainerc20 standard #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is another possible failure mode of different token addresses between chains. The fix for this would be to have good deterministic deployment tooling around battle tested create2 deployers |
Ethnical
reviewed
Oct 4, 2024
Ethnical
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
This make sense with the current
https://github.com/ethereum-optimism/design-docs/blob/main/protocol/superchainERC20/superc20Redesign.md
- I would like to know also what happen if people are sending token directly to the
SuperchainERC20Bridgedo we have method to rescue them?
Can this put the bridge in a inconsistent state (like if this is usingSuperTokenERC20.balanceOf(this);). This probably bit out of the scope but I am interested in it.
Otherwise looks go to me 🚀
|
Sure, @Ethnical. Currently, there is no plan to add a rescue method yet; for now, we prefer to stick with minimal logic around the contract. Regarding the possibility of an inconsistent state, the bridge doesn’t hold state or care about its token balance, so it shouldn’t be a problem. Here is a reference implementation. |
tynes
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the FMA for the
SuperchainERC20standard.Additional context
It will allow the use of the
SuperchainERC20standard without requiring interop functionalities to be enabled at that time.