Conversation
…to feat/update_deploy_for_testnet
| for (uint32 i = 0; i < numContexts; i++) { | ||
| BatchContext memory context = _getBatchContext(i); | ||
| _validateBatchContext(context, nextQueueIndex); | ||
| // _validateBatchContext(context, nextQueueIndex); |
There was a problem hiding this comment.
Did you mean to comment this out?
| export const deploy = async ( | ||
| config: RollupDeployConfig | ||
| ): Promise<DeployResult> => { | ||
| console.log('Beginning deploy') |
There was a problem hiding this comment.
These logs will break the deployer container
| .attach(contracts.Proxy__OVM_L1CrossDomainMessenger.address) | ||
| await xDomainMessenger.initialize(AddressManager.address) | ||
| await AddressManager.setAddress( | ||
| await (await xDomainMessenger.initialize(AddressManager.address, config.deployOverrides)).wait() |
There was a problem hiding this comment.
Not a huge fan of nested awaits on the same line, it feels pretty busy
|
See this approach for a faster approach: https://github.com/ethereum-optimism/contracts-v2/pull/51/files#diff-3d2aa7498c1a7bdecb7dfd7b4b32db4b9002a9dd0093316455609da76ff952f1R60 |
Unfortunately on Goerli sending more than 1 transaction without waiting for the receipt often causes the deployment to fail :( So that should work if mempool management was better but unfortunately we've had issues in the past. |
smartcontracts
added
Category: Enhancement
karlfloersch
force-pushed
the
feat/update_deploy_for_testnet
branch
from
1124a44 to
5a6b745
Compare
|
Closing in favor of #99 |
3 participants
Currently deployments fail often, this PR makes them slower but more consistent.
Contributing Agreement