Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.

EOA and Decompressor#33

Merged
K-Ho merged 44 commits intomasterfrom
IS-87/Fees/EOAAndDecompression
Nov 11, 2020
Merged

EOA and Decompressor#33
K-Ho merged 44 commits intomasterfrom
IS-87/Fees/EOAAndDecompression

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Oct 24, 2020

Description

Questions

Metadata

Fixes

  • Fixes # [Link to Issue]

Contributing Agreement

@K-Ho K-Ho changed the title [WIP] EOA and Decompressor EOA and Decompressor Oct 27, 2020
@karlfloersch
Copy link
Contributor

Still a WIP but fixing the broken tests

Copy link
Collaborator

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok LGTM.

TransactionType
)
{
if (_transactionType == 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to add quick comment here to explain why we're using 0 and 2.

@smartcontracts
Copy link
Collaborator

Resolved merge conflicts.

@K-Ho K-Ho merged commit 797c633 into master Nov 11, 2020
@smartcontracts smartcontracts deleted the IS-87/Fees/EOAAndDecompression branch February 2, 2021 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants