rvgo: Fix inverted hint writing conditional check #61
+205
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcw109550
force-pushed
the
tip/pcw109550/fix-inverted-hint-ineq
branch
from
6456dfa to
7973aaf
Compare
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 70.39% 70.46% +0.07%
==========================================
Files 19 19
Lines 2810 2810
==========================================
+ Hits 1978 1980 +2
+ Misses 743 742 -1
+ Partials 89 88 -1 ☔ View full report in Codecov by Sentry. |
ImTei
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix hint writing logic at
vm.go. Equal bug compared with ethereum-optimism/optimism#10514.Tests
Mirrored unit test and fuzz test.
Ensured syscall instruction is 4 bytes written, for avoiding fuzz test failure.