Skip to content

Conversation

@pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Apr 17, 2024

Description

op-challenger on the monorepo wraps around the FPVM contract using hardcorded ABI generated for MIPS.sol. It calls oracle method to access public preimageoracle address embedded in the contract.

To make this compatible, I have changed the name of variable which stores the preimage oracle address at RISCV.sol to oracle as well.

Another approach can be, making op-challenger more configurable, taking ABI as a argument, but I thought changing the VM contract is easier.

Updated contract bindings.

Current MIPS binding metadata:

{"type":"function","name":"oracle","inputs":[],"outputs":[{"name":"oracle_","type":"address","internalType":"contractIPreimageOracle"}],"stateMutability":"view"}

Updated RISCV binding metadata:

{"type":"function","name":"oracle","inputs":[],"outputs":[{"name":"","type":"address","internalType":"contractIPreimageOracle"}],"stateMutability":"view"}

@pcw109550 pcw109550 requested a review from ImTei April 17, 2024 15:57
@pcw109550 pcw109550 marked this pull request as ready for review April 17, 2024 15:57
@pcw109550 pcw109550 added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit f208a8c Apr 17, 2024
@pcw109550 pcw109550 mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants