rvsol: RISCV.sol Compatibility with MIPS.sol #54
Merged
+22
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
op-challenger on the monorepo wraps around the FPVM contract using hardcorded ABI generated for
MIPS.sol. It callsoraclemethod to access public preimageoracle address embedded in the contract.To make this compatible, I have changed the name of variable which stores the preimage oracle address at
RISCV.soltooracleas well.Another approach can be, making op-challenger more configurable, taking ABI as a argument, but I thought changing the VM contract is easier.
Updated contract bindings.
Current MIPS binding metadata:
Updated RISCV binding metadata: