Skip to content

Fix fast VM storeMemUnaligned() #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Fix fast VM storeMemUnaligned() #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rvgo/fast/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func (inst *InstrumentedState) riscvStep() (outErr error) {
inst.trackMemAccess(rightAddr, proofIndexR)
}
inst.verifyMemChange(rightAddr, proofIndexR)
s.Memory.SetUnaligned(addr, bytez[leftSize:size])
s.Memory.SetUnaligned(rightAddr, bytez[leftSize:size])
}

storeMem := func(addr U64, size U64, value U64, proofIndexL uint8, proofIndexR uint8, verifyL bool, verifyR bool) {
Expand Down
1 change: 0 additions & 1 deletion rvgo/test/syscall_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,6 @@ func FuzzStateSyscallGetrlimit(f *testing.F) {

testGetrlimit := func(t *testing.T, addr, pc, step uint64) {
pc = pc & 0xFF_FF_FF_FF_FF_FF_FF_FC // align PC
addr = addr &^ 31
state := &fast.VMState{
PC: pc,
Heap: 0,
Expand Down