Skip to content

rvsol: Lint CI job #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2024
Merged

rvsol: Lint CI job #27

merged 3 commits into from
Mar 26, 2024
+717 −397

Conversation

@ImTei
Copy link
Collaborator

@ImTei ImTei commented Mar 22, 2024 •
edited
Loading

Description

  • Add config for forge fmt. referred to optimism contracts-bedrock package
  • Add make command for rvsol lint
  • Add CI job for rvsol lint
  • Fix lint errors
  • Add license identifier

@ImTei ImTei requested a review from pcw109550 March 22, 2024 03:34
@ImTei
Copy link
Collaborator Author

ImTei commented Mar 22, 2024

I think we may set https://book.getfoundry.sh/reference/config/formatter#single_line_statement_blocks to single even if the monorepo doesn't. wdyt? @pcw109550

@ImTei ImTei changed the title rvsol Lint CI job rvsol: Lint CI job Mar 22, 2024
@ImTei ImTei added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit 122e520 Mar 26, 2024
@pcw109550 pcw109550 mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcw109550 pcw109550 pcw109550 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ImTei @pcw109550