feat: Proper contract ABI for RISCV.sol
#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pcw109550
changed the base branch from
tip/pcw109550/rename-Step-to-RISCV
to
master
pcw109550
force-pushed
the
tip/pcw109550/riscv-abi
branch
2 times, most recently
from
86e7a55 to
7784a93
Compare
pcw109550
force-pushed
the
tip/pcw109550/riscv-abi
branch
from
7784a93 to
6ee8a31
Compare
ImTei
reviewed
Feb 19, 2024
pcw109550
force-pushed
the
tip/pcw109550/riscv-abi
branch
from
a0ce152 to
fe92e30
Compare
ImTei
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables easy interaction with
RISCV.solin solidity foundry. Refer to ethereum-optimism/optimism#6597.Tests
Test added for asserting RISCV ABI. State and proof for the
test_step_abi_succeedstest is generated from the first step(starting from zero step) ofsimplebinary.Additional context
Current dependencies on/for this PR:
RISCV.sol#19 (this PR)