feat: Fetch PreimageOracle from upstream #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcw109550
force-pushed
the
tip/pcw109550/fetch-monorepo-contracts
branch
from
953dbcb to
d706fbf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
PreimageOracle.solduplication. Empty testStep.t.solhints foundry to compilePreimageOracle.solto run rvgo test becauseStep.solitself does not have dependency toPreimageOracle.sol, but only interface.Tests
Tests are removed because those were testing PreimageOracle, which is duplicated at upstream. Will add tests for
Step.solin separate PR. Currently empty test fileStep.t.solis placed.Additional context
Current dependencies on/for this PR:
Step.sol#12