Fixes plugin architecture on the client side when used from inside IFrames (e.g. from linestylefilter.js)#558
Merged
Merged
Conversation
|
I have merged this into my repo and it works, no conflicts either :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file linestylefilter.js:32 requires the "hooks" module in order to notify client plugins of "aceAttribsToClasses" event. This does not work because the: plugin architecture is not initialized in the current IFrame. To test it, put a console.log(require("./pluginfw/plugins")) statement in linestylefilter.js and you'll see that it does not know of any plugins.
This patch makes the plugin architecture available from the first parent supporting require statements.