Fix popup positioning, add response message to API calls for etherpad-lite-client to work#208
Open
ilmartyrk wants to merge 11 commits intoether:mainfrom
Open
Fix popup positioning, add response message to API calls for etherpad-lite-client to work#208ilmartyrk wants to merge 11 commits intoether:mainfrom
ilmartyrk wants to merge 11 commits intoether:mainfrom
Conversation
Member
|
Apologies, I just noticed this PR. Please rebase onto latest main. |
2 tasks
Member
|
@JohnMcLear Could be interesting to review and merge this. |
Member
|
@SamTV12345 it's 99% certain I wont get time to review each plugin. Sorry! |
Member
|
No problem. I could test it. But I don't have write access to this and most of the other plugin repositories. No idea why because I'm in every team. |
Member
|
@ilmartyrk Could you please rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The positioning of inline comment input form would go out of view when text is on the left side of document, added check to see if popup is out of view and if is then position is set to fit in view. Etherpad-lite-client expects OK response to include message, added the message part